Japanese (ja) translation group

Hi all,

As you see on Transifex, ja_JP is now 8th most translated language and more than some others which are already in recent standard production releases. I think now it is time to include ja_JP into the next release package (3.3.3?). Does anyone know how to trigger such an action?

3 Likes

I’d say by writing here you just did! We’ll have a look next week.

1 Like

cf. New translation demo instance - #3 by dirk?

Did the Japanese language get added to the latest version of Indico? I looked on the CERN site and it still isn’t enabled. Is there something more we need to do to get there?

Running a self-hosted instance here on 3.3.3. Also no Japanese in there yet. I know I could manually add it, but was thinking it would be part of the standard release by now.

@tallthom, @adam, did you check the jp translation on https://localization-demo.getindico.io/?
Can you judge, if it is at a satisfying level now? There were some points raised above, which should be settled before the first official release maybe?

Do you have an update on this, @ThiefMaster/@troun?

The duplication of the character for month (月) remains in some places though this isn’t consistent across the site.

I’ll look for other problems, will list them up and post them here. Really would love to see this completed. Most of what I saw is spot on, I may propose some changes through transifex.

Cheers

1 Like

The duplication of the character for month (月) remains in some places though this isn’t consistent across the site.

We have a fix for it, though it also makes some other translations look a bit less good: i18n: Correctly expand fields in 'format_skeleton' by tomasr8 · Pull Request #6293 · indico/indico · GitHub

If you find any other issues, please let us know! Other than that, I don’t think there is anything else preventing us from including Japanese in the next release. I just had a quick look and there are only couple issues with the format strings and html tags. I’d be happy if you could help us fix them on Transifex:

Missing format strings:

Found invalid format strings in ja_JP/LC_MESSAGES/messages-react.po
Every {number} weeks | 毎週
['{number}'] != []
Every {number} months | 毎月
['{number}'] != []

Found invalid format strings in ja_JP/LC_MESSAGES/messages.po
Settings saved ({0}) | 設定が保存されました
['{0}'] != []

Missing HTML tags:

Found mismatched HTML tags in ja_JP/LC_MESSAGES/messages-js.po
The <strong>starting time</strong> of the session interval <strong> | セッション期間の<strong>開始時間</strong>は、
['</strong>', '<strong>', '<strong>'] != ['</strong>', '<strong>']
The <strong>ending time</strong> of the session interval <strong> | セッション期間の<strong>終了時間</strong>は、
['</strong>', '<strong>', '<strong>'] != ['</strong>', '<strong>']

Found mismatched HTML tags in ja_JP/LC_MESSAGES/messages.po
Your <strong>primary email</strong> will be used for account-related notifications (e.g. registration emails and billing information). | プライマリーメールアドレスは、(登録確認メールや請求書の送付等)アカウントに関連した通知に使われます。
['</strong>', '<strong>'] != []
This object is <strong>only</strong> accessible by the <strong>users specified</strong> above and the <strong>managers</strong> of <strong>parent resources</strong>. | このオブジェクトへは、上に示されている<stribg>特定のユーザー</strong> および <strong>親リソース</strong>の<strong>管理者</strong><strong>のみ</strong>がアクセスできます。
['</strong>', '</strong>', '</strong>', '</strong>', '<strong>', '<strong>', '<strong>', '<strong>'] != ['</strong>', '</strong>', '</strong>', '</strong>', '<stribg>', '<strong>', '<strong>', '<strong>']

Cheers,
Tomas

OK, fixed those. What else needs doing?

1 Like

Thanks! All looks good on my side :slight_smile:

What else needs doing?

As Dirk mentioned, you could have a look at our demo instance and see if you can spot any obvious issues (typos, etc…).

1 Like

I’ve been looking through the demo… so far everything is looking OK to me. I’ll try to get some of my Japanese colleagues to look at it.

3 Likes

I’ve had a bit of a look around the demo site. It all looks quite good. As mentioned earlier, the duplication of the character for month (月) remains in some places, though this cannot be fixed in Transifex.

Some of the word choices might have better candidates. For example, the katakana form タイムテーブル is used for “timetable” (multiple strings), though I sometimes feel that 時間割 would be better. Still, I feel it would be better to deploy the translation and get feedback from actual users as to whether such changes should be made.

Also, though we fixed the CJK fonts for the book of contributions, other PDFs generated seem to still suffer from that issue. As I understand it, this is less of a translation issue and more a problem with how the PDFs are generated.

So, it seems to me that the Japanese translation is ready to deploy. What are the chances we could get Japanese added to 3.3.5? If there’s anything further I can do to help make this happen. please let me know.

Feeling a bit excited about this… :smiley:

Thank you both for checking!

What are the chances we could get Japanese added to 3.3.5?

We already have an open PR for it so it’s pretty much a guarantee :slight_smile:

As for the duplicate month character, we’ll try to fix it in the same release as well.
A colleague of mine is currently working on fixing the PDF timetable but that one is a larger change so it might come a bit later :slight_smile:

1 Like

As for the duplicate month character, we’ll try to fix it in the same release as well.

Just to give an update, this has now been fixed and will be included in the next minor release which will come out soon :slight_smile:

Just an FYI, @akustra rewrote the Timetable PDF generation so that it supports CJK fonts (and it also looks way better now). It should most likely be available in the next minor release (3.3.6) :slight_smile:

1 Like