Error if payment inconsistency occurs

Development Plugin Development
1

There seems to be a new error in Indico 3.2.3. If an inconsistency in payment is detected, our payment plugin triggers notify_amount_inconsistency(registration, amount, currency) from indico.modules.events.payment.notifications. While this worked fine previously, the function was changed and now we get

[...]
notify_amount_inconsistency(
  File "[...]/indico/core/notifications.py", line 28, in wrapper
    mails = fn(*args, **kwargs)
  File "[...]/indico/modules/events/payment/notifications.py", line 19, in notify_amount_inconsistency
    return make_email(to, template=tpl)
  File "[...]/indico/util/signals.py", line 111, in _wrapper
    return func(*args, **kwargs)
  File "[...]/indico/core/notifications.py", line 154, in make_email
    subject = template.get_subject()
AttributeError: 'TemplateModule' object has no attribute 'get_subject'

Or do we do something wrong?

2

Did you override the payment_inconsistency_email_to_manager.txt template somehow? It must inherit from {% extends 'emails/base_i18n.txt' %} (or emails/base.txt).

3

Not to my knowledge, but I’ll check.

4

Thanks for the help.
First, I did not expect template file to cause an object to lose a function.
Second, did we override the template? Yes and no :smiley: Someone copied the template into the custom folder without changing it, so it went unnoticed.

5

Template modules are basically a “compiled” version of the template (templates are internally compiled to Python), where all its macros are exposed as methods.

6

It would be very helpful if the error contained the path to the template in question :slight_smile: